N21-1219 adds adjustments

hpi-schul-cloud · Nov 1, 2023 · c5af33e · c5af33e
1 parent 1f4fc89
commit c5af33e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 32 deletions.
diff --git a/apps/server/src/modules/authentication/mapper/current-user.mapper.spec.ts b/apps/server/src/modules/authentication/mapper/current-user.mapper.spec.ts
@@ -219,16 +219,6 @@ describe('CurrentUserMapper', () => {
 					impersonated: jwtPayload.support,
 				});
 			});
-
-			/* it('should return current user with default for isExternalUser', () => {
-				const { jwtPayload } = setup();
-
-				const currentUser = CurrentUserMapper.jwtToICurrentUser(jwtPayload);
-
-				expect(currentUser).toMatchObject({
-					isExternalUser: jwtPayload.isExternalUser,
-				});
-			}); */
 		});
 
 		describe('when JWT is provided without optional claims', () => {
@@ -238,7 +228,6 @@ describe('CurrentUserMapper', () => {
 					roles: ['mockRoleId'],
 					schoolId: 'dummySchoolId',
 					userId: 'dummyUserId',
-					// isExternalUser: false,
 					sub: 'dummyAccountId',
 					jti: 'random string',
 					aud: 'some audience',
@@ -264,16 +253,6 @@ describe('CurrentUserMapper', () => {
 					userId: jwtPayload.userId,
 				});
 			});
-
-			/* it('should return current user with default for isExternalUser', () => {
-				const { jwtPayload } = setup();
-
-				const currentUser = CurrentUserMapper.jwtToICurrentUser(jwtPayload);
-
-				expect(currentUser).toMatchObject({
-					isExternalUser: false,
-				});
-			}); */
 		});
 	});
 

diff --git a/apps/server/src/modules/oauth/uc/oauth.uc.ts b/apps/server/src/modules/oauth/uc/oauth.uc.ts
@@ -63,9 +63,6 @@ export class OauthUc {
 		return authenticationUrl;
 	}
 
-	/**
-	 * @deprecated Please use the oauth2 strategy instead.
-	 */
 	async processOAuthLogin(cachedState: OauthLoginStateDto, code?: string, error?: string): Promise<OAuthProcessDto> {
 		const { state, systemId, postLoginRedirect, userLoginMigration } = cachedState;
 

diff --git a/apps/server/src/modules/user/service/user.service.ts b/apps/server/src/modules/user/service/user.service.ts
@@ -1,17 +1,16 @@
-import { ConfigService } from '@nestjs/config';
-import { EntityId, IFindOptions, LanguageType, User } from '@shared/domain';
-import { RoleReference, Page, UserDO } from '@shared/domain/domainobject';
-import { UserRepo } from '@shared/repo';
-import { UserDORepo } from '@shared/repo/user/user-do.repo';
 import { AccountService } from '@modules/account';
 import { AccountDto } from '@modules/account/services/dto';
-import { ICurrentUser } from '@modules/authentication';
 // invalid import
 import { CurrentUserMapper } from '@modules/authentication/mapper';
 import { RoleDto } from '@modules/role/service/dto/role.dto';
 import { RoleService } from '@modules/role/service/role.service';
 import { BadRequestException, Injectable } from '@nestjs/common';
-import { OauthCurrentUser } from '../../authentication/interface';
+import { ConfigService } from '@nestjs/config';
+import { EntityId, IFindOptions, LanguageType, User } from '@shared/domain';
+import { Page, RoleReference, UserDO } from '@shared/domain/domainobject';
+import { UserRepo } from '@shared/repo';
+import { UserDORepo } from '@shared/repo/user/user-do.repo';
+import { OauthCurrentUser } from '@modules/authentication/interface';
 import { IUserConfig } from '../interfaces';
 import { UserMapper } from '../mapper/user.mapper';
 import { UserDto } from '../uc/dto/user.dto';

diff --git a/apps/server/src/modules/video-conference/uc/video-conference-deprecated.uc.spec.ts b/apps/server/src/modules/video-conference/uc/video-conference-deprecated.uc.spec.ts
@@ -172,7 +172,6 @@ describe('VideoConferenceUc', () => {
 			roles: [],
 			schoolId: 'schoolId',
 			accountId: 'accountId',
-			isExternalUser: false,
 		};
 		defaultOptions = {
 			everybodyJoinsAsModerator: false,