EW-709 fixing tests

hpi-schul-cloud · Mar 15, 2024 · 918e070 · 918e070
1 parent bb92ba1
commit 918e070
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/apps/server/src/modules/board/service/column.service.spec.ts b/apps/server/src/modules/board/service/column.service.spec.ts
@@ -38,6 +38,10 @@ describe(ColumnService.name, () => {
 		await module.close();
 	});
 
+	beforeEach(() => {
+		jest.clearAllMocks();
+	});
+
 	describe('findById', () => {
 		describe('when finding a column', () => {
 			const setup = () => {

diff --git a/apps/server/src/modules/common-cartridge/import/common-cartridge-manifest-parser.spec.ts b/apps/server/src/modules/common-cartridge/import/common-cartridge-manifest-parser.spec.ts
@@ -98,8 +98,7 @@ describe('CommonCartridgeManifestParser', () => {
 				const { sut } = await setup();
 				const result = sut.getOrganizations();
 
-				expect(result).toBe('201510-AMH-2020-70C-12218-US History Since 1877');
-				expect.any(String);
+				expect(result).toHaveLength(117);
 			});
 		});
 
@@ -110,7 +109,7 @@ describe('CommonCartridgeManifestParser', () => {
 				const { sut } = await setup();
 				const result = sut.getOrganizations();
 
-				expect(result).toBe([]);
+				expect(result).toHaveLength(0);
 			});
 		});
 	});

diff --git a/...server/src/modules/common-cartridge/import/utils/common-cartridge-organization-visitor.ts b/...server/src/modules/common-cartridge/import/utils/common-cartridge-organization-visitor.ts
@@ -1,4 +1,4 @@
-import { UUID } from 'bson';
+import { randomUUID } from 'crypto';
 import { CommonCartridgeFileParserOptions, OrganizationProps } from '../common-cartridge-import.types';
 
 type SearchElement = { depth: number; path: string; element: Element };
@@ -74,7 +74,7 @@ export class CommonCartridgeOrganizationVisitor {
 	}
 
 	private getElementIdentifier(element: Element): string {
-		const identifier = element.getAttribute('identifier') ?? `i${UUID.generate().toString()}`;
+		const identifier = element.getAttribute('identifier') ?? `i${randomUUID()}`;
 
 		return identifier;
 	}