some cleanup

src/services/sync/index.js

@@ -53,8 +53,7 @@ module.exports = function setup() {
 			}
 		}
 	}
-	// @TODO - i don't why but if i create a get methode it work without error
-	// @virgilchiriac we need to check this
+
 	app.use('/sync/userAccount', new UserAccountService(), { methods: [] });
 
 	app.use('/sync/api', staticContent(path.join(__dirname, '/docs/openapi.yaml')));

src/services/sync/services/UserAccountService.js

@@ -8,6 +8,7 @@ class UserAccountService {
 		this.lock = new Semaphore(5);
 	}
 
+	// Feathers 5: at least one standard service method must be implemented to be considered a service
 	get() {
 		return undefined;
 	}

test/services/ldap/strategies/general.test.js

@@ -37,16 +37,18 @@ const mockLDAPConfig = {
 	},
 };
 
-const createLDAPUserResult = (props) => ({
-	dn: 'uid=max.mustermann.1,ou=users,o=school0,dc=de,dc=example,dc=org',
-	givenName: 'Max',
-	sn: 'Mustermann',
-	uid: 'max.mustermann.1',
-	uuid: 'ZDg0Y2ZlMjMtZGYwNi00MWNjLTg3YmUtZjI3NjA1NDJhY2Y0',
-	mail: '[email protected]',
-	memberOf: 'cn=ROLE_STUDENT,ou=roles,o=school0,dc=de,dc=example,dc=org',
-	...props,
-});
+const createLDAPUserResult = (props) => {
+	return {
+		dn: 'uid=max.mustermann.1,ou=users,o=school0,dc=de,dc=example,dc=org',
+		givenName: 'Max',
+		sn: 'Mustermann',
+		uid: 'max.mustermann.1',
+		uuid: 'ZDg0Y2ZlMjMtZGYwNi00MWNjLTg3YmUtZjI3NjA1NDJhY2Y0',
+		mail: '[email protected]',
+		memberOf: 'cn=ROLE_STUDENT,ou=roles,o=school0,dc=de,dc=example,dc=org',
+		...props,
+	};
+};
 
 describe('GeneralLDAPStrategy', () => {
 	it('implements AbstractLDAPStrategy', () => {
@@ -67,10 +69,6 @@ describe('GeneralLDAPStrategy', () => {
 		app.use('/ldap', originalLdapService);
 	});
 
-	afterEach(() => {
-		app.unuse('/ldap');
-	});
-
 	describe('#getSchools', () => {
 		it('should return school compliant with internal interface', async () => {
 			const schools = await new GeneralLDAPStrategy(app, mockLDAPConfig).getSchools();
@@ -144,6 +142,7 @@ describe('GeneralLDAPStrategy', () => {
 
 		beforeEach(() => {
 			ldapServiceMock = new MockLdapService();
+			app.unuse('/ldap');
 			app.use('/ldap', ldapServiceMock);
 		});
 
@@ -270,8 +269,8 @@ describe('GeneralLDAPStrategy', () => {
 		}
 
 		beforeEach(() => {
-			//app.unuse('/ldap');
 			ldapServiceMock = new MockLdapService();
+			app.unuse('/ldap');
 			app.use('/ldap', ldapServiceMock);
 		});