antaresKey is optional now

hpi-schul-cloud · Sep 28, 2023 · 862e587 · 862e587
1 parent 559d8ed
commit 862e587
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 12 deletions.
diff --git a/apps/server/src/modules/federal-state/controller/dto/county.response.ts b/apps/server/src/modules/federal-state/controller/dto/county.response.ts
@@ -1,4 +1,4 @@
-import { ApiProperty } from '@nestjs/swagger';
+import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
 import { DecodeHtmlEntities } from '@shared/controller';
 import { IsNumber, IsString } from 'class-validator';
 
@@ -17,8 +17,8 @@ export class CountyResponse {
 	@IsNumber()
 	countyId: number;
 
-	@ApiProperty()
+	@ApiPropertyOptional()
 	@IsString()
 	@DecodeHtmlEntities()
-	antaresKey: string;
+	antaresKey?: string;
 }
diff --git a/apps/server/src/modules/federal-state/controller/dto/create-county.body.params.ts b/apps/server/src/modules/federal-state/controller/dto/create-county.body.params.ts
@@ -1,4 +1,4 @@
-import { ApiProperty } from '@nestjs/swagger';
+import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
 import { DecodeHtmlEntities } from '@shared/controller';
 import { IsNumber, IsString } from 'class-validator';
 
@@ -18,10 +18,9 @@ export class CreateCountyBodyParams {
 
 	@IsString()
 	@DecodeHtmlEntities()
-	@ApiProperty({
+	@ApiPropertyOptional({
 		description: 'Antares key of the county',
-		required: true,
 		type: String,
 	})
-	antaresKey!: string;
+	antaresKey?: string;
 }
diff --git a/apps/server/src/modules/federal-state/domainobject/federal-state.do.ts b/apps/server/src/modules/federal-state/domainobject/federal-state.do.ts
@@ -3,7 +3,7 @@ import { AuthorizableObject, DomainObject } from '@shared/domain/domain-object';
 export interface ICounty {
 	countyId: number;
 	name: string;
-	antaresKey: string;
+	antaresKey?: string;
 }
 export interface FederalStateProps extends AuthorizableObject {
 	name: string;

diff --git a/apps/server/src/modules/federal-state/entity/federal-state.entity.ts b/apps/server/src/modules/federal-state/entity/federal-state.entity.ts
@@ -25,7 +25,7 @@ export class County {
 	countyId: number;
 
 	@Property()
-	antaresKey: string;
+	antaresKey?: string;
 }
 
 @Entity({ tableName: 'federalstates' })

diff --git a/apps/server/src/modules/federal-state/interface/IFederalStateCreate.ts b/apps/server/src/modules/federal-state/interface/IFederalStateCreate.ts
@@ -1,7 +1,7 @@
 export interface ICountyCreate {
 	name: string;
 	countyId: number;
-	antaresKey: string;
+	antaresKey?: string;
 }
 
 export interface IFederalStateCreate {

diff --git a/apps/server/src/modules/federal-state/service/federal-state.service.ts b/apps/server/src/modules/federal-state/service/federal-state.service.ts
@@ -13,8 +13,8 @@ export class FederalStateService {
 		return federalState;
 	}
 
-	async findAll() {
-		const federalStates: FederalStateDO[] = await this.federalStateRepo.findAll();
+	async findAll(): Promise<FederalStateDO[]> {
+		const federalStates = await this.federalStateRepo.findAll();
 		return federalStates;
 	}