BC-4293 - Topic does not copy with empty content Learning material (#…

…4485)

* copy lernstore content without set resource

apps/server/src/modules/lesson/service/lesson-copy.service.spec.ts

@@ -531,6 +531,55 @@ describe('lesson copy service', () => {
 		});
 	});
 
+	describe('when lesson contains LernStore content element without set resource', () => {
+		const setup = () => {
+			const lernStoreContent: IComponentProperties = {
+				title: 'text component 1',
+				hidden: false,
+				component: ComponentType.LERNSTORE,
+			};
+			const user = userFactory.build();
+			const originalCourse = courseFactory.build({ school: user.school });
+			const destinationCourse = courseFactory.build({ school: user.school, teachers: [user] });
+			const originalLesson = lessonFactory.build({
+				course: originalCourse,
+				contents: [lernStoreContent],
+			});
+			lessonRepo.findById.mockResolvedValueOnce(originalLesson);
+
+			return { user, originalCourse, destinationCourse, originalLesson, lernStoreContent };
+		};
+
+		it('the content should be fully copied', async () => {
+			const { user, destinationCourse, originalLesson, lernStoreContent } = setup();
+
+			const status = await copyService.copyLesson({
+				originalLessonId: originalLesson.id,
+				destinationCourse,
+				user,
+			});
+
+			const copiedLessonContents = (status.copyEntity as LessonEntity).contents as IComponentProperties[];
+			expect(copiedLessonContents[0]).toEqual(lernStoreContent);
+		});
+
+		it('should set content type to LESSON_CONTENT_LERNSTORE', async () => {
+			const { user, destinationCourse, originalLesson } = setup();
+
+			const status = await copyService.copyLesson({
+				originalLessonId: originalLesson.id,
+				destinationCourse,
+				user,
+			});
+			const contentsStatus = status.elements?.find((el) => el.type === CopyElementType.LESSON_CONTENT_GROUP);
+			expect(contentsStatus).toBeDefined();
+			if (contentsStatus?.elements) {
+				expect(contentsStatus.elements[0].type).toEqual(CopyElementType.LESSON_CONTENT_LERNSTORE);
+				expect(contentsStatus.elements[0].status).toEqual(CopyStatusEnum.SUCCESS);
+			}
+		});
+	});
+
 	describe('when lesson contains geoGebra content element', () => {
 		const setup = () => {
 			const geoGebraContent: IComponentProperties = {

apps/server/src/modules/lesson/service/lesson-copy.service.ts

@@ -266,29 +266,32 @@ export class LessonCopyService {
 	}
 
 	private copyLernStore(element: IComponentProperties): IComponentProperties {
-		const resources = ((element.content as IComponentLernstoreProperties).resources ?? []).map(
-			({ client, description, merlinReference, title, url }) => {
-				const result = {
-					client,
-					description,
-					merlinReference,
-					title,
-					url,
-				};
-				return result;
-			}
-		);
-
-		const lernstore = {
+		const lernstore: IComponentProperties = {
 			title: element.title,
 			hidden: element.hidden,
 			component: ComponentType.LERNSTORE,
 			user: element.user, // TODO should be params.user - but that made the server crash, but property is normally undefined
-			content: {
-				resources,
-			},
 		};
-		return lernstore as IComponentProperties;
+
+		if (element.content) {
+			const resources = ((element.content as IComponentLernstoreProperties).resources ?? []).map(
+				({ client, description, merlinReference, title, url }) => {
+					const result = {
+						client,
+						description,
+						merlinReference,
+						title,
+						url,
+					};
+					return result;
+				}
+			);
+
+			const lernstoreContent: IComponentLernstoreProperties = { resources };
+			lernstore.content = lernstoreContent;
+		}
+
+		return lernstore;
 	}
 
 	private static copyGeogebra(originalElement: IComponentProperties): IComponentProperties {

apps/server/src/shared/domain/entity/lesson.entity.ts

@@ -73,7 +73,7 @@ export type IComponentProperties = {
 	| { component: ComponentType.ETHERPAD; content: IComponentEtherpadProperties }
 	| { component: ComponentType.GEOGEBRA; content: IComponentGeogebraProperties }
 	| { component: ComponentType.INTERNAL; content: IComponentInternalProperties }
-	| { component: ComponentType.LERNSTORE; content: IComponentLernstoreProperties }
+	| { component: ComponentType.LERNSTORE; content?: IComponentLernstoreProperties }
 	| { component: ComponentType.NEXBOARD; content: IComponentNexboardProperties }
 );