Skip to content

Commit

Permalink
Remove comments
Browse files Browse the repository at this point in the history
  • Loading branch information
dyedwiper committed Nov 16, 2023
1 parent c0fcf67 commit 79e676d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions apps/server/src/modules/school/api/school.uc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ export class SchoolUc {

const schools = await this.schoolService.getAllSchoolsExceptOwnSchool(query, ownSchoolId, findOptions);

// TODO: Do we want authorization here? At the moment there is no fitting permission.

const dtos = SchoolResponseMapper.mapToListForExternalInviteResponses(schools);

return dtos;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,4 @@ export interface SchoolRepo {
getSchool(schoolId: EntityId): Promise<School>;
}

// TODO: How to name the injection token? Should it be a string or a symbol? There are different approaches in our code. Shall we be consistent about it?
// It is even possible to give it the same name as the interface: https://stackoverflow.com/a/70088972/11854580 But that's probably confusing.
export const SCHOOL_REPO = 'SCHOOL_REPO';

0 comments on commit 79e676d

Please sign in to comment.