Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@hoeppner-dataport
hoeppner-dataport committed Dec 12, 2024
1 parent 42788ea commit 6a74c75
Showing 1 changed file with 94 additions and 85 deletions.
179 changes: 94 additions & 85 deletions apps/server/src/modules/room-membership/service/room-membership.service.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -169,118 +169,127 @@ describe('RoomMembershipService', () => {
});

describe('when roomMembership exists', () => {
const setup = () => {
const user = userFactory.buildWithId();
const setupGroupAndRoom = (schoolId: string) => {
const group = groupFactory.build({ type: GroupTypes.ROOM });
const room = roomFactory.build();
const roomMembership = roomMembershipFactory.build({ roomId: room.id, userGroupId: group.id });

roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
groupService.findById.mockResolvedValue(group);
groupService.findGroups.mockResolvedValue({ total: 1, data: [group] });
const room = roomFactory.build({ schoolId });
const roomMembership = roomMembershipFactory.build({
roomId: room.id,
userGroupId: group.id,
schoolId,
});

return {
user,
room,
roomMembership,
group,
};
return { group, room, roomMembership };
};

it('should remove roomMembership', async () => {
const { user, room, group } = setup();

await service.removeMembersFromRoom(room.id, [user.id]);

expect(groupService.removeUsersFromGroup).toHaveBeenCalledWith(group.id, [user.id]);
});
});
const mockGroupsAtSchoolAfterRemoval = (groups: Group[]) => {
groupService.findGroups.mockResolvedValue({ total: groups.length, data: groups });
};

const setupUserWithSecondarySchool = () => {
const secondarySchool = schoolFactory.build();
const otherSchool = schoolFactory.build();
const role = roleFactory.buildWithId({ name: RoleName.TEACHER });
const guestTeacher = roleFactory.buildWithId({ name: RoleName.GUESTTEACHER });
const externalUser = userDoFactory.buildWithId({
roles: [role],
secondarySchools: [{ schoolId: secondarySchool.id, role: new RoleDto(guestTeacher) }],
});
const setupUserWithSecondarySchool = () => {
const secondarySchool = schoolFactory.build();
const otherSchool = schoolFactory.build();
const role = roleFactory.buildWithId({ name: RoleName.TEACHER });
const guestTeacher = roleFactory.buildWithId({ name: RoleName.GUESTTEACHER });
const externalUser = userDoFactory.buildWithId({
roles: [role],
secondarySchools: [{ schoolId: secondarySchool.id, role: new RoleDto(guestTeacher) }],
});

return { secondarySchool, externalUser, otherSchool };
};
return { secondarySchool, externalUser, otherSchool };
};

const setupGroupAndRoom = (schoolId: string) => {
const group = groupFactory.build({ type: GroupTypes.ROOM });
const room = roomFactory.build({ schoolId });
const roomMembership = roomMembershipFactory.build({
roomId: room.id,
userGroupId: group.id,
schoolId,
});
it('should pass the schoolId of the room', async () => {
const { secondarySchool, externalUser } = setupUserWithSecondarySchool();

return { group, room, roomMembership };
};
const roomEditorRole = roleFactory.buildWithId({ name: RoleName.ROOMEDITOR });

const mockGroupsAtSchoolAfterRemoval = (groups: Group[]) => {
groupService.findGroups.mockResolvedValue({ total: groups.length, data: groups });
};
const { room, group, roomMembership } = setupGroupAndRoom(secondarySchool.id);
group.addUser({ userId: externalUser.id as string, roleId: roomEditorRole.id });

it('should pass the schoolId of the room', async () => {
const { secondarySchool, externalUser } = setupUserWithSecondarySchool();
roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
groupService.findById.mockResolvedValue(group);
groupService.removeUsersFromGroup.mockResolvedValue(group);
mockGroupsAtSchoolAfterRemoval([]);

const roomEditorRole = roleFactory.buildWithId({ name: RoleName.ROOMEDITOR });
await service.removeMembersFromRoom(room.id, [externalUser.id as string]);

const { room, group, roomMembership } = setupGroupAndRoom(secondarySchool.id);
group.addUser({ userId: externalUser.id as string, roleId: roomEditorRole.id });
expect(groupService.findGroups).toHaveBeenCalledWith(expect.objectContaining({ schoolId: secondarySchool.id }));
});

roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
groupService.findById.mockResolvedValue(group);
groupService.removeUsersFromGroup.mockResolvedValue(group);
mockGroupsAtSchoolAfterRemoval([]);
it('should remove roomMembership', async () => {
const user = userFactory.buildWithId();
const { room, group, roomMembership } = setupGroupAndRoom(user.school.id);
const roomOwnerRole = roleFactory.buildWithId({ name: RoleName.ROOMOWNER });
groupService.findById.mockResolvedValue(group);
roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
roleService.findByName.mockResolvedValue(roomOwnerRole);
mockGroupsAtSchoolAfterRemoval([group]);

await service.removeMembersFromRoom(room.id, [externalUser.id as string]);
await service.removeMembersFromRoom(room.id, [user.id]);

expect(groupService.findGroups).toHaveBeenCalledWith(expect.objectContaining({ schoolId: secondarySchool.id }));
});
expect(groupService.removeUsersFromGroup).toHaveBeenCalledWith(group.id, [user.id]);
});

describe('when after removal: user is not in any room of that secondary school', () => {
it('should remove user from secondary school', async () => {
const { secondarySchool, externalUser } = setupUserWithSecondarySchool();
describe('when after removal: user is not in any room of that secondary school', () => {
it('should remove user from secondary school', async () => {
const { secondarySchool, externalUser } = setupUserWithSecondarySchool();

const { room, group, roomMembership } = setupGroupAndRoom(secondarySchool.id);
const roomEditorRole = roleFactory.buildWithId({ name: RoleName.ROOMEDITOR });
group.addUser({ userId: externalUser.id as string, roleId: roomEditorRole.id });
const { room, group, roomMembership } = setupGroupAndRoom(secondarySchool.id);
const roomOwnerRole = roleFactory.buildWithId({ name: RoleName.ROOMOWNER });
const roomEditorRole = roleFactory.buildWithId({ name: RoleName.ROOMEDITOR });
group.addUser({ userId: externalUser.id as string, roleId: roomEditorRole.id });

roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
groupService.findById.mockResolvedValue(group);
groupService.removeUsersFromGroup.mockResolvedValue(group);
mockGroupsAtSchoolAfterRemoval([]);
roleService.findByName.mockResolvedValue(roomOwnerRole);
roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
groupService.findById.mockResolvedValue(group);
groupService.removeUsersFromGroup.mockResolvedValue(group);
mockGroupsAtSchoolAfterRemoval([]);

await service.removeMembersFromRoom(room.id, [externalUser.id as string]);
await service.removeMembersFromRoom(room.id, [externalUser.id as string]);

expect(userService.removeSecondarySchoolFromUsers).toHaveBeenCalledWith([externalUser.id], secondarySchool.id);
expect(userService.removeSecondarySchoolFromUsers).toHaveBeenCalledWith(
[externalUser.id],
secondarySchool.id
);
});
});
});

describe('when after removal: user is still in a room of that secondary school', () => {
it('should not remove user from secondary school', async () => {
const { secondarySchool, externalUser } = setupUserWithSecondarySchool();
describe('when after removal: user is still in a room of that secondary school', () => {
it('should not remove user from secondary school', async () => {
const { secondarySchool, externalUser } = setupUserWithSecondarySchool();

const roomEditorRole = roleFactory.buildWithId({ name: RoleName.ROOMEDITOR });
const roomOwnerRole = roleFactory.buildWithId({ name: RoleName.ROOMOWNER });
const roomEditorRole = roleFactory.buildWithId({ name: RoleName.ROOMEDITOR });

const { room, group, roomMembership } = setupGroupAndRoom(secondarySchool.id);
group.addUser({ userId: externalUser.id as string, roleId: roomEditorRole.id });
const { group: group2 } = setupGroupAndRoom(secondarySchool.id);
group2.addUser({ userId: externalUser.id as string, roleId: roomEditorRole.id });
const { room, group, roomMembership } = setupGroupAndRoom(secondarySchool.id);
group.addUser({ userId: externalUser.id as string, roleId: roomEditorRole.id });
const { group: group2 } = setupGroupAndRoom(secondarySchool.id);
group2.addUser({ userId: externalUser.id as string, roleId: roomEditorRole.id });

roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
groupService.findById.mockResolvedValue(group);
groupService.removeUsersFromGroup.mockResolvedValue(group);
mockGroupsAtSchoolAfterRemoval([group2]);
roleService.findByName.mockResolvedValue(roomOwnerRole);
roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
groupService.findById.mockResolvedValue(group);
groupService.removeUsersFromGroup.mockResolvedValue(group);
mockGroupsAtSchoolAfterRemoval([group2]);

await service.removeMembersFromRoom(room.id, [externalUser.id as string]);
await service.removeMembersFromRoom(room.id, [externalUser.id as string]);

expect(userService.removeSecondarySchoolFromUsers).not.toHaveBeenCalled();
expect(userService.removeSecondarySchoolFromUsers).not.toHaveBeenCalled();
});
});

describe('when owner should be removed', () => {
it('should throw a badrequest exception', async () => {
const user = userFactory.buildWithId();
const { room, group, roomMembership } = setupGroupAndRoom(user.school.id);
roomMembershipRepo.findByRoomId.mockResolvedValue(roomMembership);
const roomOwnerRole = roleFactory.buildWithId({ name: RoleName.ROOMOWNER });
group.addUser({ userId: user.id, roleId: roomOwnerRole.id });
groupService.findById.mockResolvedValue(group);
roleService.findByName.mockResolvedValue(roomOwnerRole);

await expect(service.removeMembersFromRoom(room.id, [user.id])).rejects.toThrowError(BadRequestException);
});
});
});
});
Expand Down

0 comments on commit 6a74c75

Please sign in to comment.