EW-1081: Make ptscListKlasseId optional in TspJwtPayload.

hpi-schul-cloud · Dec 5, 2024 · 69f45e3 · 69f45e3
1 parent 60c0702
commit 69f45e3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/apps/server/src/modules/provisioning/service/tsp-provisioning.service.ts b/apps/server/src/modules/provisioning/service/tsp-provisioning.service.ts
@@ -188,7 +188,7 @@ export class TspProvisioningService {
 		return email.toLowerCase();
 	}
 
-	private createTspConsent(user: UserDO) {
+	private createTspConsent(user: UserDO): void {
 		const userConsent = new UserConsent({
 			form: 'digital',
 			privacyConsent: true,

diff --git a/apps/server/src/modules/provisioning/strategy/tsp/tsp.jwt.payload.ts b/apps/server/src/modules/provisioning/strategy/tsp/tsp.jwt.payload.ts
@@ -27,8 +27,8 @@ export class TspJwtPayload implements JwtPayload {
 	public ptscSchuleNummer!: string;
 
 	@IsString()
-	@IsNotEmpty()
-	public ptscListKlasseId!: string;
+	@IsOptional()
+	public ptscListKlasseId?: string;
 
 	constructor(data: Partial<TspJwtPayload>) {
 		Object.assign(this, data);

diff --git a/apps/server/src/modules/provisioning/strategy/tsp/tsp.strategy.ts b/apps/server/src/modules/provisioning/strategy/tsp/tsp.strategy.ts
@@ -23,11 +23,11 @@ export class TspProvisioningStrategy extends ProvisioningStrategy {
 		super();
 	}
 
-	getType(): SystemProvisioningStrategy {
+	public getType(): SystemProvisioningStrategy {
 		return SystemProvisioningStrategy.TSP;
 	}
 
-	override async getData(input: OauthDataStrategyInputDto): Promise<OauthDataDto> {
+	public override async getData(input: OauthDataStrategyInputDto): Promise<OauthDataDto> {
 		const decodedAccessToken: JwtPayload | null = jwt.decode(input.accessToken, { json: true });
 
 		if (!decodedAccessToken) {
@@ -60,8 +60,8 @@ export class TspProvisioningStrategy extends ProvisioningStrategy {
 		});
 
 		const externalClassDtoList = payload.ptscListKlasseId
-			.split(',')
-			.map((externalId) => new ExternalClassDto({ externalId }));
+			? payload.ptscListKlasseId.split(',').map((externalId) => new ExternalClassDto({ externalId }))
+			: [];
 
 		const oauthDataDto = new OauthDataDto({
 			system: input.system,
@@ -73,7 +73,7 @@ export class TspProvisioningStrategy extends ProvisioningStrategy {
 		return oauthDataDto;
 	}
 
-	override async apply(data: OauthDataDto): Promise<ProvisioningDto> {
+	public override async apply(data: OauthDataDto): Promise<ProvisioningDto> {
 		if (!data.externalSchool) {
 			throw new BadDataLoggableException('External school is missing for user', {
 				externalId: data.externalUser.externalId,