BC-7800 improved exception message

hpi-schul-cloud · Aug 6, 2024 · 47eedbe · 47eedbe
1 parent dac2bd9
commit 47eedbe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/apps/server/src/modules/learnroom/mapper/rolename.mapper.spec.ts b/apps/server/src/modules/learnroom/mapper/rolename.mapper.spec.ts
@@ -21,7 +21,7 @@ describe('rolename mapper', () => {
 	const setup = () => {
 		const teacherUser = userFactory.asTeacher().buildWithId();
 		const studentUser = userFactory.asStudent().buildWithId();
-		const course = courseFactory.build({
+		const course = courseFactory.buildWithId({
 			teachers: [teacherUser],
 			students: [studentUser],
 		});
@@ -48,6 +48,8 @@ describe('rolename mapper', () => {
 		const role = roleFactory.build({ name: RoleName.EXPERT });
 		const user = userFactory.buildWithId({ roles: [role] });
 
-		expect(() => RoleNameMapper.mapToRoleName(user, course)).toThrowError('Unsupported role');
+		expect(() => RoleNameMapper.mapToRoleName(user, course)).toThrowError(
+			`Unable to determine a valid role for user ${user.id} in course ${course.id}`
+		);
 	});
 });
diff --git a/apps/server/src/modules/learnroom/mapper/rolename.mapper.ts b/apps/server/src/modules/learnroom/mapper/rolename.mapper.ts
@@ -33,6 +33,8 @@ export class RoleNameMapper {
 		if (RoleNameMapper.isSubstitutionTeacher(user, course)) return RoleName.COURSESUBSTITUTIONTEACHER;
 		if (RoleNameMapper.isStudent(user, course)) return RoleName.STUDENT;
 
-		throw new UnprocessableEntityException('Unsupported role');
+		throw new UnprocessableEntityException(
+			`Unable to determine a valid role for user ${user.id} in course ${course.id}`
+		);
 	}
 }