BC-8063 - Remove excess Method from BoardNode (#5232)

hpi-schul-cloud · Sep 10, 2024 · 2490c16 · 2490c16
1 parent c7708ca
commit 2490c16
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/apps/server/src/modules/board/domain/board-node.do.ts b/apps/server/src/modules/board/domain/board-node.do.ts
@@ -21,17 +21,10 @@ export abstract class BoardNode<T extends BoardNodeProps> extends DomainObject<T
 		// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 		// @ts-ignore
 		copyProps.domainObject = undefined;
-		// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-		// @ts-ignore
-		copyProps.children = [];
 
 		return copyProps;
 	}
 
-	public getTrueProps(): T {
-		return this.props;
-	}
-
 	get level(): number {
 		return this.ancestorIds.length;
 	}

diff --git a/apps/server/src/modules/board/service/board-node.service.spec.ts b/apps/server/src/modules/board/service/board-node.service.spec.ts
@@ -164,7 +164,7 @@ describe(BoardNodeService.name, () => {
 				const parentNode = cardFactory.build();
 				parentNode.addChild(oldNode);
 
-				boardNodeRepo.findById.mockResolvedValueOnce(new Card({ ...parentNode.getTrueProps() }));
+				boardNodeRepo.findById.mockResolvedValueOnce(new Card({ ...parentNode.getProps() }));
 
 				return {
 					parentNode,
@@ -179,7 +179,7 @@ describe(BoardNodeService.name, () => {
 				await service.replace(oldNode, newNode);
 
 				expect(boardNodeRepo.save).toHaveBeenCalledWith(
-					new Card({ ...parentNode.getTrueProps(), children: [oldNode, newNode] })
+					new Card({ ...parentNode.getProps(), children: [oldNode, newNode] })
 				);
 			});