Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-7842 - downgrade npm #3502

Merged
merged 1 commit into from
Aug 16, 2024
Merged

BC-7842 - downgrade npm #3502

merged 1 commit into from
Aug 16, 2024

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Aug 14, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

BC-7842
hpi-schul-cloud/schulcloud-server#5178

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@virgilchiriac virgilchiriac mentioned this pull request Aug 14, 2024
Merged
3 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@virgilchiriac virgilchiriac merged commit c6024d5 into main Aug 16, 2024
46 of 49 checks passed
@virgilchiriac virgilchiriac deleted the BC-7842-downgrade-npm branch August 16, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzzatOmar EzzatOmar EzzatOmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virgilchiriac @EzzatOmar