Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2106 Fix oauth school feature #3492

Merged
merged 6 commits into from
Jul 26, 2024
Merged

N21-2106 Fix oauth school feature #3492

merged 6 commits into from
Jul 26, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jul 25, 2024 •
edited by arnegns
Loading

Description

Links to Tickets or other pull requests

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Jul 25, 2024
Merged
3 tasks
arnegns
arnegns approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@arnegns arnegns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please inform pos about that change

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit af4735c into main Jul 26, 2024
45 of 46 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-2106-fix-school-features branch July 26, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @arnegns