Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-2057 Team invitations with duplicate emails #3485

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jul 17, 2024

Description

Links to Tickets or other pull requests

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

static/scripts/teamMembers.js Outdated Show resolved Hide resolved
@@ -3057,7 +3057,8 @@
"pleaseSelectRole": "Bitte wähle eine Rolle aus.",
"selectTeacherFromRegisterOrInvitePerEmail": "Wähle eine Lehrkraft anderer Schulen aus einem zentralen Verzeichnis aus oder gib die E-Mail-Adresse an, mit der sie registriert ist. Nach Beitritt zu deinem Team kann sie Schüler:innen und Lehrkräfte ihrer Schule zum Team hinzufügen.",
"teacherIsFromOtherSchool": "Lehrkraft ist an einer anderen Schule",
"teachersRegisterProcessFinished": "Registrierung der Lehrkraft in der {{ rootThemeShortTitle }} ist abgeschlossen"
"teachersRegisterProcessFinished": "Registrierung der Lehrkraft in der {{ rootThemeShortTitle }} ist abgeschlossen",
"multipleTeachersWithEmail": "Es wurden mehrere Lehrkräfte mit dieser E-Mail gefunden. Bitte wähle die gewollte Lehrkraft aus:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Bitte wähle die gewollte Lehrkraft aus:" if isnt a text of the requirement please ask ba.

Copy link

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 2ca9d50 into main Jul 18, 2024
45 of 46 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-2057-duplicate-emails branch July 18, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants