BC-7618 - Missing breadcrumbs #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
views/lib/loggedin.hbs
Outdated
| @@ -255,6 +255,17 @@ | |||
| <div class="container-fluid"> | |||
| <div class="row" id="titlebar"> | |||
| <div class="col-sm-9"> | |||
| <div style="margin-bottom: 0.4rem; font-size: 14px;"> | |||
There was a problem hiding this comment.
fix formating
should the if not contain the div? If no breadcrumbs, there would be a div which has some size. Is this wanted?
views/lib/loggedin.hbs
Outdated
| @@ -121,7 +121,7 @@ | |||
| <a class="sc-branding" href="/" title="{{$t "global.link.landing"}}" data-testid="{{$t "global.link.landing"}}"> | |||
| <div class="cloud-logo"></div> | |||
| </a> | |||
| {{#if breadcrumb}} | |||
| {{!-- {{#if breadcrumb}} | |||
There was a problem hiding this comment.
should be removed instead of commented
views/lib/loggedin.hbs
Outdated
| <span> | ||
| {{#each this.breadcrumbs}} | ||
| {{#if this.title}} | ||
| <a class="{{#if @last}}active{{/if}}" href="{{this.url}}">{{{stripOnlyScript this.title}}} </a> / |
There was a problem hiding this comment.
remove the space before closing
you could add remove the space and / but that is also not good.... best is to use css
virgilchiriac
approved these changes
Jul 5, 2024
odalys-dataport
approved these changes
Jul 5, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-7618
Changes
Data Security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Approval for review