Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7614 - Update Landing-Page (logged out) SC BB: Adjustment of support times #3475

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Jul 3, 2024

Description

Auf der Startseite Brandenburg https://brandenburg.cloud/ soll das Info-Feld zur "Allgemeine Anfragen & Support" angepasst werden.

Links to Tickets or other pull requests

BC-7614

Changes

  • removing phone1, phone2 and online chat info on landing page brb

Screenshots of UI changes

grafik

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher self-assigned this Jul 3, 2024
Copy link
Member

@Loki-Afro Loki-Afro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not comment out code,remove it if it's not for demonstration purposes

Copy link
Member

@Loki-Afro Loki-Afro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History lives in git,not in comments

Copy link

sonarqubecloud bot commented Jul 4, 2024

@MartinSchuhmacher MartinSchuhmacher enabled auto-merge (squash) July 4, 2024 07:23
@MartinSchuhmacher MartinSchuhmacher merged commit 5ad8882 into main Jul 4, 2024
45 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-7614-brb-landing branch July 4, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants