Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7523- remove duplicated data-testid #3468

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

odalys-dataport
Copy link
Contributor

@odalys-dataport odalys-dataport commented Jun 25, 2024

Description

The user menu button in the legacy client has a duplicated data-testid, one of which needs to be removed.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-7523

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@odalys-dataport odalys-dataport self-assigned this Jun 25, 2024
Copy link

@odalys-dataport odalys-dataport enabled auto-merge (squash) June 25, 2024 11:53
@odalys-dataport odalys-dataport merged commit ab9840f into main Jun 25, 2024
41 of 46 checks passed
@odalys-dataport odalys-dataport deleted the BC-7523-duplicated-test-id branch June 25, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants