Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1859 Prevent login and migration for multipe users #3438

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented Apr 12, 2024

Description

This PR will reject the migration if user want to migrate to an already migrated account. Also the PR will reject the login if more then one user is found by externalId.

Links to Tickets or other pull requests

hpi-schul-cloud/nuxt-client#3197
hpi-schul-cloud/schulcloud-server#4921
https://ticketsystem.dbildungscloud.de/browse/N21-1859

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

locales/de.json Outdated Show resolved Hide resolved
@mrikallab mrikallab changed the title N21-1859 Prevent login and migration N21-1859 Prevent login and migration for multipe users Apr 12, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mrikallab mrikallab merged commit 77ca92b into main Apr 16, 2024
46 of 47 checks passed
@mrikallab mrikallab deleted the N21-1859-prevent-login-and-migration branch April 16, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants