Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "BC-4121 - Replace old with new school adminstration page (#32… #3399

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Revert "BC-4121 - Replace old with new school adminstration page (#32… #3399

merged 1 commit into from
Jan 29, 2024

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Jan 29, 2024 •
edited
Loading

…47)"

This reverts commit d3d9ab0.

Description

Links to Tickets or other pull requests

hpi-schul-cloud/dof_app_deploy#767
hpi-schul-cloud/schulcloud-server#4723
hpi-schul-cloud/nuxt-client#3053

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

This was referenced Jan 29, 2024
Merged
Merged
Merged
@davwas davwas merged commit 8dd29e1 into main Jan 29, 2024
41 of 43 checks passed
@davwas davwas deleted the BC-4121-revert-replace-school-admin-page branch January 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

@wiaderwek wiaderwek wiaderwek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davwas @wiaderwek @SevenWaysDP