Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1455 Fix BBB pulsating dot in reduced animation mode #3344

Merged
merged 1 commit into from
Nov 8, 2023
Merged

N21-1455 Fix BBB pulsating dot in reduced animation mode #3344

merged 1 commit into from
Nov 8, 2023

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Nov 8, 2023 •
edited by arnegns
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1455
hpi-schul-cloud/nuxt-client#2897

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Nov 8, 2023
Merged
3 tasks
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 28a8136 into main Nov 8, 2023
40 of 41 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1455-bbb-animation branch November 8, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @arnegns