Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1318 replace classes with new classes in administration and sidebar #3341

Merged
merged 5 commits into from
Nov 5, 2023

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Oct 27, 2023

Description

As we are finishing the new class page feature, we want to replace the old classes overview page with our new one, if the feature flag FEATURE_SHOW_NEW_CLASS_VIEW_ENABLED is activated

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1318
hpi-schul-cloud/schulcloud-server#4496
hpi-schul-cloud/nuxt-client#2879

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

helpers/handlebars/middleware.js Outdated Show resolved Hide resolved
views/administration/dashboard.hbs Outdated Show resolved Hide resolved
views/administration/dashboard.hbs Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IgorCapCoder IgorCapCoder merged commit fbb2a24 into main Nov 5, 2023
40 of 41 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1318-complete-new-class-page branch November 5, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants