Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5536 - Add Information about user survey (for teachers only) in multi-message-banner #3340

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Oct 26, 2023

Description

New message in announcement bar on dashboard for teacher only.

Links to Tickets or other pull requests

BC-5536
hpi-schul-cloud/dof_app_deploy#683

Changes

  • new message in dashboard announcement for teacher only
  • adjust code style to more general approach (instead of bettermarks specific)

Deployment

From ticket: "To be merged on 6th November to meet target release date. (depending on actual release planning)"

Screenshots of UI changes

grafik

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MartinSchuhmacher MartinSchuhmacher added do_not_merge Do not merge and removed do_not_merge Do not merge labels Oct 27, 2023
@MartinSchuhmacher MartinSchuhmacher merged commit 1d59fb6 into main Nov 2, 2023
74 of 75 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-5536-user-survey branch November 2, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants