Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1273 calling logout endpoint from external oauth system #3331

Merged
merged 28 commits into from
Oct 13, 2023
Merged

N21-1273 calling logout endpoint from external oauth system #3331

merged 28 commits into from
Oct 13, 2023

Conversation

arnegns
Copy link
Contributor

@arnegns arnegns commented Oct 11, 2023 •
edited
Loading

Description

Redirects after successful login to the logoutEndpoint and back to redirect from query or /dashboard.'

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1273
hpi-schul-cloud/schulcloud-server#4467

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@arnegns arnegns changed the title N21-1273 calling auth logout endpoint N21-1273 calling logout endpoint from idp Oct 11, 2023
@arnegns arnegns changed the title N21-1273 calling logout endpoint from idp N21-1273 calling logout endpoint from external oauth system Oct 11, 2023
@arnegns arnegns mentioned this pull request Oct 11, 2023
Merged
3 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 11, 2023
View reviewed changes
helpers/authentication.js Dismissed Show dismissed Hide dismissed
MarvinOehlerkingCap
MarvinOehlerkingCap approved these changes Oct 11, 2023
View reviewed changes
helpers/authentication.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.0% 5.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arnegns arnegns merged commit 8667d18 into main Oct 13, 2023
39 checks passed
@arnegns arnegns deleted the N21-1273-adds-externalidtoken-to-icurruser branch October 13, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnegns @MarvinOehlerkingCap