Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1219 hide email section #3325

Merged
merged 4 commits into from
Nov 2, 2023
Merged

N21-1219 hide email section #3325

merged 4 commits into from
Nov 2, 2023

Conversation

arnegns
Copy link
Contributor

@arnegns arnegns commented Oct 5, 2023

Description

Hides email section on first login when isExternalUser in jwt is set.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1219
hpi-schul-cloud/schulcloud-server#4455

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@arnegns arnegns enabled auto-merge (squash) November 2, 2023 09:37
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arnegns arnegns merged commit 8b04f3e into main Nov 2, 2023
39 of 40 checks passed
@arnegns arnegns deleted the N21-1219-hide-email-section branch November 2, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants