N21-1206 show classes and goups #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
IgorCapCoder
approved these changes
Sep 19, 2023
arnegns
approved these changes
Sep 21, 2023
| @@ -1748,6 +1748,7 @@ | |||
| "addons": "Add-ons", | |||
| "administration": "Administration", | |||
| "administrationClasses": "Klassen", | |||
| "administrationClassesNew": "Klassen (neu)", | |||
There was a problem hiding this comment.
Something for BB. We need a ticket to remove the "(neu)"
arnegns
suggested changes
Sep 21, 2023
helpers/handlebars/middleware.js
Outdated
| }, | ||
| ]; | ||
|
|
||
| const newClassViewEnabled = FEATURE_SHOW_NEW_CLASS_VIEW_ENABLED === 'true'; |
There was a problem hiding this comment.
What is the requirement? Actually we only show this menu if we click on a menu item with sub items.
On the "Verwaltung" page we cant see the new menu: https://nbc-n21-1206-show-classes-and-goups.cd.dbildungscloud.dev/administration
arnegns
approved these changes
Sep 22, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1206
hpi-schul-cloud/schulcloud-server#4406
hpi-schul-cloud/dof_app_deploy#643
hpi-schul-cloud/nuxt-client#2808
Changes
Data Security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Approval for review