Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8427- Improve A11y of add and remove member dialog #3467

Merged
merged 34 commits into from
Dec 19, 2024
+669 −203
Merged

BC-8427- Improve A11y of add and remove member dialog #3467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
6e90ec8
add vueuse focus trap
NFriedo Dec 4, 2024
7dc4c0b
close dialog with esc
NFriedo Dec 4, 2024
0bf0afe
add focus trap for add members dialog
NFriedo Dec 4, 2024
528e8ae
WIP: add focus trap remove dialog
NFriedo Dec 4, 2024
c25cbf8
Merge branch 'main' into BC-8427-member-dialogs-a11y
NFriedo Dec 5, 2024
6ec5504
add todos, remove focus trap from custom dialog
NFriedo Dec 5, 2024
4dd9439
Merge branch 'main' into BC-8427-member-dialogs-a11y
NFriedo Dec 11, 2024
7a08ca6
use onDialogClose
NFriedo Dec 11, 2024
9f71f84
add name for actions table header
NFriedo Dec 11, 2024
7b123e8
Revert "add name for actions table header"
NFriedo Dec 11, 2024
8bd6949
WIP: repalce custom dialog with v-dialog
NFriedo Dec 11, 2024
9fd0ee6
add focus trap for confirmation dialog
NFriedo Dec 12, 2024
e29124a
remove custom dialog
NFriedo Dec 12, 2024
40eae14
add styling for remove dialog
NFriedo Dec 13, 2024
9fcf6f4
Merge branch 'main' into BC-8427-member-dialogs-a11y
NFriedo Dec 13, 2024
26b3b8a
adjust styling
NFriedo Dec 13, 2024
386a5bb
adjust margin action buttons
NFriedo Dec 13, 2024
551a595
add tabbable mock for focus trap
NFriedo Dec 13, 2024
904c6b2
refactor AddMembers test to not use wrapperVm
NFriedo Dec 13, 2024
bb9341c
add tests confirm dialog
NFriedo Dec 13, 2024
67b5d0c
make dialog tests independent
NFriedo Dec 16, 2024
0f00ba6
Merge branch 'main' into BC-8427-member-dialogs-a11y
NFriedo Dec 16, 2024
5d9f177
fix and add tests for confirmation dialog
NFriedo Dec 16, 2024
5016bac
fix tests
NFriedo Dec 16, 2024
ab45e43
fix room member page
NFriedo Dec 16, 2024
d67ee0b
mock focus trap in room member page
NFriedo Dec 16, 2024
9278f30
Merge branch 'main' into BC-8427-member-dialogs-a11y
NFriedo Dec 16, 2024
ade9a65
add tests add members
NFriedo Dec 17, 2024
6c0335c
fix bug when opening a different autocomplete than the currently open…
NFriedo Dec 17, 2024
5fe5dfd
add test for closing dialog via escape key
NFriedo Dec 17, 2024
7dfc2db
Merge branch 'main' into BC-8427-member-dialogs-a11y
NFriedo Dec 17, 2024
ddc0d33
add tests
NFriedo Dec 17, 2024
ffb17ed
add tests for focus trap
NFriedo Dec 17, 2024
e31c571
Merge branch 'main' into BC-8427-member-dialogs-a11y
NFriedo Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
244 changes: 183 additions & 61 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"@vuelidate/validators": "^2.0.4",
"@vueuse/components": "^10.11.0",
"@vueuse/core": "^10.11.0",
"@vueuse/integrations": "^12.0.0",
"axios": "^1.7.4",
"cross-env": "^7.0.3",
"dayjs": "^1.11.10",
Expand Down
Loading
Loading