Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1679 ctl config states #3230

Merged
merged 29 commits into from
May 7, 2024
Merged

N21-1679 ctl config states #3230

merged 29 commits into from
May 7, 2024

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented May 2, 2024 •
edited
Loading

Short Description

This PR will introduce new ctl state incomplete operational. Tools that are incomplete operational should be launchable, if they have no outdated state. Also text changes and chip/Alert visualization is adapted.

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@mrikallab mrikallab changed the title N21-1679-ctl-config-states N21-1679 ctl config states May 2, 2024
IgorCapCoder
IgorCapCoder requested changes May 2, 2024
View reviewed changes
src/components/rooms/RoomExternalToolCard.vue Outdated Show resolved Hide resolved
src/locales/de.ts Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.ts Outdated Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.ts Outdated Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.ts Outdated Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.unit.ts Outdated Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.unit.ts Outdated Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.unit.ts Outdated Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.unit.ts Outdated Show resolved Hide resolved
src/serverApi/v3/api.ts Outdated
@@ -1490,6 +1496,7 @@ export interface CopyApiResponse {
export enum CopyApiResponseTypeEnum {
Board = 'BOARD',
Card = 'CARD',
CollaborativeTextEditorElement = 'COLLABORATIVE_TEXT_EDITOR_ELEMENT',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this here? :O

MarvinOehlerkingCap
MarvinOehlerkingCap requested changes May 3, 2024
View reviewed changes
src/components/rooms/RoomExternalToolCard.vue Outdated Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.ts Outdated Show resolved Hide resolved
src/modules/feature/board-external-tool-element/ExternalToolElement.vue Outdated Show resolved Hide resolved
src/components/rooms/RoomExternalToolCard.vue Outdated Show resolved Hide resolved
src/modules/feature/board-external-tool-element/ExternalToolElementAlert.vue Outdated Show resolved Hide resolved
src/modules/feature/board-external-tool-element/ExternalToolElementAlert.vue Outdated Show resolved Hide resolved
src/modules/feature/board-external-tool-element/ExternalToolElementAlert.vue Outdated Show resolved Hide resolved
IgorCapCoder
IgorCapCoder previously approved these changes May 6, 2024
View reviewed changes
MarvinOehlerkingCap
MarvinOehlerkingCap requested changes May 6, 2024
View reviewed changes
src/components/rooms/RoomExternalToolCard.vue Outdated Show resolved Hide resolved
src/components/rooms/RoomExternalToolCard.vue Outdated Show resolved Hide resolved
src/components/rooms/RoomExternalToolCard.vue Outdated Show resolved Hide resolved
src/modules/data/external-tool/ContextExternalToolConfigurationStatus.composable.ts Outdated Show resolved Hide resolved
src/modules/feature/board-external-tool-element/ExternalToolElement.vue Outdated Show resolved Hide resolved
src/modules/feature/board-external-tool-element/ExternalToolElement.vue Outdated Show resolved Hide resolved
src/modules/ui/chip/InfoChip.unit.ts Outdated Show resolved Hide resolved
src/modules/ui/chip/InfoChip.unit.ts Outdated Show resolved Hide resolved
src/modules/ui/chip/InfoChip.unit.ts Outdated Show resolved Hide resolved
src/modules/ui/chip/WarningChip.unit.ts Show resolved Hide resolved
@MBergCap MBergCap mentioned this pull request May 6, 2024
Merged
1 task
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mrikallab mrikallab merged commit 4837f39 into main May 7, 2024
48 of 49 checks passed
@mrikallab mrikallab deleted the N21-1679-ctl-config-states branch May 7, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

@IgorCapCoder IgorCapCoder IgorCapCoder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrikallab @IgorCapCoder @MarvinOehlerkingCap