Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EW-694 Common Cartridge Course Import #3010

Merged
merged 43 commits into from
Mar 13, 2024
Merged

EW-694 Common Cartridge Course Import #3010

merged 43 commits into from
Mar 13, 2024

Conversation

psachmann
Copy link
Contributor

@psachmann psachmann commented Jan 17, 2024 •
edited
Loading

Short Description

Adding a new modal and import/upload dialog to allow users the import of courses from Common Cartridge files.

Links to Ticket and related Pull-Requests

Deployment

Environment variables FEATURE_COMMON_CARTRIDGE_IMPORT_ENABLED must be set to true.

Screenshots of UI changes

Upload Button
Unselected Upload File
Selected Upload File

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@psachmann psachmann self-assigned this Jan 17, 2024
@psachmann psachmann mentioned this pull request Jan 22, 2024
Merged
3 tasks
@psachmann psachmann marked this pull request as ready for review January 26, 2024 07:30
Fshmit
Fshmit previously approved these changes Jan 30, 2024
View reviewed changes
mkreuzkam-cap
mkreuzkam-cap previously approved these changes Jan 30, 2024
View reviewed changes
@psachmann psachmann dismissed stale reviews from mkreuzkam-cap and Fshmit via b1ba6d9 February 1, 2024 11:36
SevenWaysDP
SevenWaysDP previously approved these changes Feb 29, 2024
View reviewed changes
mkreuzkam-cap
mkreuzkam-cap requested changes Mar 12, 2024
View reviewed changes
src/locales/en.ts Outdated Show resolved Hide resolved
src/store/rooms.unit.ts Outdated Show resolved Hide resolved
mkreuzkam-cap
mkreuzkam-cap previously approved these changes Mar 13, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@psachmann psachmann enabled auto-merge (squash) March 13, 2024 12:59
@psachmann psachmann merged commit b057bdf into main Mar 13, 2024
46 of 48 checks passed
@psachmann psachmann deleted the EW-694 branch March 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkreuzkam-cap mkreuzkam-cap mkreuzkam-cap approved these changes

@Fshmit Fshmit Fshmit left review comments

@SevenWaysDP SevenWaysDP SevenWaysDP left review comments

Assignees

@psachmann psachmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psachmann @SevenWaysDP @Fshmit @mkreuzkam-cap