BC-5119 - Prevent creating new nexboards #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
wiaderwek
previously approved these changes
Dec 8, 2023
odalys-dataport
requested changes
Dec 11, 2023
# Conflicts: # src/locales/en.json # src/locales/es.json # src/locales/uk.json
odalys-dataport
previously approved these changes
Dec 12, 2023
wiaderwek
previously approved these changes
Dec 12, 2023
# Conflicts: # src/components/copy-result-modal/CopyResultModal.unit.ts # src/components/copy-result-modal/CopyResultModal.vue # src/components/share/ImportFlow.unit.ts # src/components/templates/TasksDashboardMain.unit.ts
davwas
dismissed stale reviews from wiaderwek and odalys-dataport
via
609a59f
wiaderwek
approved these changes
Dec 13, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
QA note:
Change tested on env:
https://nbc-bc-5119-prevent-creating-new-nexboards.cd.dbildungscloud.dev/
Tested according to the above criteria. Added tested copying and sharing of the course with the topic in the same school as in another school. NO issues found - test only checked that nothing was broken. Next step is testing on STAGING env because of missing data (course and topic with nexbord) on dev env. Required data exists on STAGING env.
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/BC-5119
hpi-schul-cloud/schulcloud-server#4624
hpi-schul-cloud/schulcloud-client#3361
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging