Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5100 - pin docker/build-push-action to version 4.1.1 #2795

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

mamutmk5
Copy link
Member

@mamutmk5 mamutmk5 commented Sep 8, 2023

Short Description

the current version 4.2.0 for the github action docker/build-push-action who is pulled if we use as version set v4 hass an issue with our metadata json so we must pin it to version 4.1.1 for now

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-5100
hpi-schul-cloud/superhero-dashboard#229
hpi-schul-cloud/antivirus_check_service#41
hpi-schul-cloud/version-aggregator#10
hpi-schul-cloud/h5p-staticfiles-server#3
hpi-schul-cloud/schulcloud-server#4396
hpi-schul-cloud/schulcloud-client#3299
hpi-schul-cloud/schulcloud-calendar#141

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@mamutmk5 mamutmk5 self-assigned this Sep 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mamutmk5 mamutmk5 merged commit dd7b9a8 into main Sep 8, 2023
@mamutmk5 mamutmk5 deleted the BC-5100 branch September 8, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants