Skip to content

Commit

Permalink
EW-795 Correcting data-testids for course import buttons (#3149)
Browse files Browse the repository at this point in the history
* Fixing data-testids
* Fixing styles for cc import modal
  • Loading branch information
psachmann authored Mar 15, 2024
1 parent 73c281f commit 7a7ad60
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
11 changes: 9 additions & 2 deletions src/components/molecules/CommonCartridgeImportModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,21 @@
<v-card-actions>
<v-spacer />
<div class="button-section">
<v-btn data-testid="dialog-cancel-btn" depressed @click="onCancel">
<v-btn
data-testid="dialog-cancel-btn"
variant="outlined"
@click="onCancel"
>
{{ $t("common.labels.close") }}
</v-btn>
</div>
<div class="button-section">
<v-btn
type="submit"
variant="flat"
color="primary"
v-bind:disabled="importButtonDisabled"
v-on:click="onConfirm"
color="primary"
data-testid="dialog-confirm-btn"
>
{{ $t("pages.rooms.ccImportCourse.confirm") }}
Expand Down Expand Up @@ -133,5 +139,6 @@ async function onConfirm(): Promise<void> {
.button-section > button {
margin-left: calc(var(--space-base-vuetify) * 2);
margin-right: calc(var(--space-base-vuetify) * 2);
}
</style>
6 changes: 3 additions & 3 deletions src/components/templates/RoomWrapper.vue
Original file line number Diff line number Diff line change
Expand Up @@ -74,19 +74,19 @@ export default defineComponent({
icon: mdiPlus,
title: this.$t("common.actions.create"),
ariaLabel: this.$t("pages.rooms.fab.ariaLabel"),
testId: "add-course-button",
dataTestId: "add-course-button",
actions: [
{
icon: mdiSchoolOutline,
label: this.$t("pages.rooms.fab.add.course"),
href: "/courses/add",
dataTestid: "fab_button_add_course",
dataTestId: "fab_button_add_course",
ariaLabel: this.$t("pages.rooms.fab.add.course"),
},
{
label: this.$t("pages.rooms.fab.import.course"),
icon: mdiImport,
dataTestid: "fab_button_import_course",
dataTestId: "fab_button_import_course",
ariaLabel: this.$t("pages.rooms.fab.import.course"),
customEvent: "import",
},
Expand Down

0 comments on commit 7a7ad60

Please sign in to comment.