test and logic fix

hpi-schul-cloud · Jan 8, 2024 · 11288ac · 11288ac
1 parent 6eb5e25
commit 11288ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/components/rooms/RoomExternalToolCard.vue b/src/components/rooms/RoomExternalToolCard.vue
@@ -16,11 +16,11 @@
 				</room-card-chip>
 				<room-card-chip
 					v-if="isToolIncomplete"
-				data-testId="tool-card-status-incomplete"
-				>{{ t("pages.rooms.tools.incomplete") }}
-			</room-card-chip>
-			<room-card-chip
-				v-if="isToolOutdated"
+					data-testId="tool-card-status-incomplete"
+					>{{ t("pages.rooms.tools.incomplete") }}
+				</room-card-chip>
+				<room-card-chip
+					v-if="isToolOutdated"
 					data-testId="tool-card-status-outdated"
 				>
 					{{ t("pages.rooms.tools.outdated") }}
@@ -133,8 +133,8 @@ export default defineComponent({
 
 		const isToolLaunchable = computed(() => {
 			return (
-				!isToolOutdated.value ||
-				!isToolDeactivated.value ||
+				!isToolOutdated.value &&
+				!isToolDeactivated.value &&
 				!isToolIncomplete.value
 			);
 		});

diff --git a/tests/test-utils/factory/schoolExternalToolConfigurationFactory.ts b/tests/test-utils/factory/schoolExternalToolConfigurationFactory.ts
@@ -6,6 +6,7 @@ export const schoolToolConfigurationStatusFactory =
 		return {
 			isOutdatedOnScopeContext: false,
 			isOutdatedOnScopeSchool: false,
+			isIncompleteOnScopeContext: false,
 			isDeactivated: false,
 		};
 	});