feat(#567): generalize message when no drugs

hpi-dhc · Apr 14, 2023 · 731b83f · 731b83f
1 parent f3811c3
commit 731b83f
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 7 deletions.
diff --git a/app/lib/common/widgets/drug_list/builder.dart b/app/lib/common/widgets/drug_list/builder.dart
@@ -1,18 +1,31 @@
 import '../../module.dart';
 
-List<Widget> buildDrugList(BuildContext context, DrugListState state) =>
+List<Widget> buildDrugList(
+  BuildContext context,
+  DrugListState state, {
+  String? noDrugsMessage,
+}) =>
     state.when(
       initial: () => [Container()],
       error: () => [errorIndicator(context.l10n.err_generic)],
-      loaded: (drugs, filter) => _buildDrugCards(context, drugs, filter),
+      loaded: (drugs, filter) => _buildDrugCards(
+        context,
+        drugs,
+        filter,
+        noDrugsMessage: noDrugsMessage,
+      ),
       loading: () => [loadingIndicator()],
     );
 
 List<Widget> _buildDrugCards(
-    BuildContext context, List<Drug> drugs, FilterState filter) {
+  BuildContext context,
+  List<Drug> drugs,
+  FilterState filter, {
+  String? noDrugsMessage,
+}) {
   final filteredDrugs = filter.filter(drugs);
-  if (filteredDrugs.isEmpty) {
-    return [errorIndicator(context.l10n.err_no_drugs)];
+  if (filteredDrugs.isEmpty && noDrugsMessage != null) {
+    return [errorIndicator(noDrugsMessage)];
   }
   return [
     SizedBox(height: 8),

diff --git a/app/lib/l10n/app_en.arb b/app/lib/l10n/app_en.arb
@@ -100,6 +100,7 @@
   "gene_page_phenotype_tooltip": "The phenotype describes the effect that your personal variant of this gene has on the enzyme it encodes.",
   "gene_page_affected_drugs": "Affected drugs",
   "gene_page_affected_drugs_tooltip": "The drugs listed here are affected by your variant of this gene.",
+  "gene_page_no_affected_drugs": "Your variant of this gene has no known effect on any drug.",
 
   "nav_report": "Report",
   "tab_report": "Gene report",

diff --git a/app/lib/report/pages/gene.dart b/app/lib/report/pages/gene.dart
@@ -49,7 +49,8 @@ class GenePage extends HookWidget {
                   SizedBox(height: 12),
                   SubHeader(context.l10n.gene_page_affected_drugs,
                       tooltip: context.l10n.gene_page_affected_drugs_tooltip),
-                  ...buildDrugList(context, state)
+                  ...buildDrugList(context, state,
+                      noDrugsMessage: context.l10n.gene_page_no_affected_drugs)
                 ],
               ),
             ),

diff --git a/app/lib/search/pages/search.dart b/app/lib/search/pages/search.dart
@@ -39,7 +39,8 @@ class SearchPage extends HookWidget {
               TooltipIcon(context.l10n.search_page_tooltip_search),
               buildFilter(context),
             ]),
-            body: buildDrugList(context, state),
+            body: buildDrugList(context, state,
+                noDrugsMessage: context.l10n.err_no_drugs),
           );
         }));
   }