Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Remove current implementation of WatchFlags #96

Closed
wants to merge 1 commit into from
Closed

Remove current implementation of WatchFlags #96

wants to merge 1 commit into from

Conversation

nathany
Copy link
Contributor

@nathany nathany commented May 24, 2014

removes fsnFlags, purgeEvents and internalEvent channel

  • current implementation doesn't take advantage of OS for efficiency
  • provides little benefit over filtering events as they are received, but has extra bookkeeping and mutexes
  • no tests for the current implementation
  • not fully implemented on Windows WatchFlags not supported on Windows? #93 (comment)

TODO: go.exp CL for this.

@nathany nathany closed this May 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant