This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Fixed .env include #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that changes to .env should be excluded from future Git commits, thanks! I'm not sure about the production test -- is this common practice? |
|
Yes, it is. Test environments have there own ways of handling environment variables. |
foxtree
reviewed
Apr 18, 2017
| if (process.env.NODE_ENV !== 'production') { | ||
| var env = require('node-env-file'); | ||
| env(__dirname + '/.env'); | ||
| } | ||
|
|
There was a problem hiding this comment.
This conditional logic would be unnecessary if dotenv were used in place of node-env-file
https://github.com/motdotla/dotenv
node-env-filealso appears to be broken, in the sense that there is unconventional behavior: ENV values that are defined later do not override those defined earlier.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of the security issue I mentioned in issue #8. Hosting services like heroku and AWS have already made provision for environmental configurations. Which is a lot more secure and gives little room for accidentally sharing sensitive informations.
I believe it is best to leave .env config file to development environment only.