Show problem with vars_ok() re lexicals declared outside sub def #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This patch is for research; it's not ready to be committed to master. In houseabsolute#44, it was argued that vars_ok() should have failed on a .pm file that simply declared three 'my' variables but never used them and never did anything else. vars_ok() returns '1' (as do the previous invocations of vars_ok() in the test file) where we would have expected it to return a Perl-false value. This patch attempts to bring that observation into the test suite in the form of a TODO test. However, we're hampered by the fact that the return value of vars_ok() is at best opaquely documented. What we really need is a function along the lines of: vars_not_expected_to_be_ok('path/to/file');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This patch is for research; it's not ready to be committed to master.
In #44, it was argued that vars_ok() should have failed on a .pm file that simply declared three 'my' variables but never used them and never did anything else. vars_ok() returns '1' (as do the previous invocations of vars_ok() in the test file) where we would have expected it to return a Perl-false value.
This patch attempts to bring that observation into the test suite in the form of a TODO test. However, we're hampered by the fact that the return value of vars_ok() is at best opaquely documented. What we really need is a function along the lines of: