Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ValidateSqlQueries which handles multiple statements per query #42

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ncabatoff
Copy link
Collaborator

I'm leaving ValidateSqlQuery unchanged, because I'm not sure if all PG drivers support multiple statements, e.g. jackc/pgx#1090 was closed as completed but I don't see anything in the changelog suggesting support was added.

… not consider multiple statements in one query to be an error.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.81%. Comparing base (5f05ce8) to head (55a93ea).

Files with missing lines Patch % Lines
pkg/vet/vet.go 0.00% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   68.45%   67.81%   -0.65%     
==========================================
  Files           9        9              
  Lines        1154     1165      +11     
==========================================
  Hits          790      790              
- Misses        290      301      +11     
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houqp houqp merged commit cc9a593 into master Sep 17, 2024
2 of 3 checks passed
@houqp houqp deleted the support-multiple-queries branch September 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants