Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DELETE USING. Add check for missing WHERE clause in DELETE. #36

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

ncabatoff
Copy link
Collaborator

Arguably this PR should be split into two, but I thought I'd first see whether the maintainer minded accepting them as a single PR, since it would've been a bit more work to split it.

The first change is to add support for DELETE USING statements.

The second change is to treat DELETE statements that don't have a WHERE clause, or that have a WHERE clause but without any column names in it, as an error. These are usually errors in my experience, and I'd prefer to have sqlvet refuse to allow them unless ignored.

@houqp
Copy link
Owner

houqp commented Apr 9, 2024

Thanks @ncabatoff it's fine to keep it as a single PR, I will review later today

@ncabatoff
Copy link
Collaborator Author

Hey @houqp, just a reminder that this could use a review when you get a chance. Thanks!

@houqp houqp merged commit 8ff20b7 into houqp:master Apr 28, 2024
1 check passed
@houqp
Copy link
Owner

houqp commented Apr 28, 2024

sorry for the delay @ncabatoff , merged.

@ncabatoff
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants