Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus with initial metrics #452

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jeffswensen
Copy link
Contributor

very much still a draft.

so far:

  • adds prometheus w/ default go metrics
  • adds searcher_started_total - counter incremented for each Searcher created
  • adds search_duration_seconds - histogram for the search API endpoint (tracks duration, count)

still to do:

  • disk usage
  • errors
  • update docs w/ instructions

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The PR fulfills these requirements:

  • All tests are passing?
  • New/updated tests are included?
  • If any static assets have been updated, has ui/bindata.go been regenerated?
  • Are there doc blocks for functions that I updated/created?

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants