-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* feat(erlang): support erlfmt * fix: use correct formatter
- Loading branch information
Showing
7 changed files
with
205 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| use super::execute_command; | ||
|
|
||
| #[inline] | ||
| pub fn format_using_erlfmt(file_path: &std::path::Path) -> std::io::Result<(bool, Option<String>)> { | ||
| let mut cmd = std::process::Command::new("erlfmt"); | ||
|
|
||
| cmd.arg("-w") | ||
| .arg(format!("'{}'", file_path.to_string_lossy())); | ||
|
|
||
| execute_command(&mut cmd, file_path) | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test_erlfmt { | ||
| use crate::{ | ||
| formatters::{erlfmt::format_using_erlfmt, setup_snippet}, | ||
| languages::Language, | ||
| }; | ||
|
|
||
| #[test_with::executable(erlfmt)] | ||
| #[test] | ||
| fn it_should_format_erlang() { | ||
| let input = "what_is(Erlang) -> | ||
| case Erlang of movie->[hello(mike,joe,robert),credits]; language->formatting_arguments end | ||
| ."; | ||
|
|
||
| let expected_output = "what_is(Erlang) -> | ||
| case Erlang of | ||
| movie -> [hello(mike, joe, robert), credits]; | ||
| language -> no_more_formatting_arguments | ||
| end."; | ||
| let snippet = setup_snippet(input, Language::Erlang.to_file_ext()) | ||
| .expect("it to create a snippet file"); | ||
|
|
||
| let output = format_using_erlfmt(snippet.path()) | ||
| .expect("it to be successful") | ||
| .1 | ||
| .expect("it to be some"); | ||
|
|
||
| assert_eq!(expected_output, output); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| use schemars::JsonSchema; | ||
|
|
||
| use crate::formatters::{erlfmt::format_using_erlfmt, MdsfFormatter}; | ||
|
|
||
| use super::{Lang, LanguageFormatter}; | ||
|
|
||
| #[derive(Debug, Default, serde::Serialize, serde::Deserialize, JsonSchema)] | ||
| #[cfg_attr(test, derive(PartialEq, Eq))] | ||
| pub enum Erlang { | ||
| #[default] | ||
| #[serde(rename = "erlfmt")] | ||
| Erlfmt, | ||
| } | ||
|
|
||
| impl Default for Lang<Erlang> { | ||
| #[inline] | ||
| fn default() -> Self { | ||
| Self { | ||
| enabled: true, | ||
| formatter: MdsfFormatter::<Erlang>::default(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Default for MdsfFormatter<Erlang> { | ||
| #[inline] | ||
| fn default() -> Self { | ||
| Self::Single(Erlang::Erlfmt) | ||
| } | ||
| } | ||
|
|
||
| impl LanguageFormatter for Erlang { | ||
| #[inline] | ||
| fn format_snippet( | ||
| &self, | ||
| snippet_path: &std::path::Path, | ||
| ) -> std::io::Result<(bool, Option<String>)> { | ||
| match self { | ||
| Self::Erlfmt => format_using_erlfmt(snippet_path), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test_erlang { | ||
| use crate::{ | ||
| formatters::{setup_snippet, MdsfFormatter}, | ||
| languages::Lang, | ||
| }; | ||
|
|
||
| use super::Erlang; | ||
|
|
||
| const INPUT: &str = "what_is(Erlang) -> | ||
| case Erlang of movie->[hello(mike,joe,robert),credits]; language->formatting_arguments end | ||
| ."; | ||
|
|
||
| const EXTENSION: &str = crate::languages::Language::Gleam.to_file_ext(); | ||
|
|
||
| #[test] | ||
| fn it_should_be_enabled_by_default() { | ||
| assert!(Lang::<Erlang>::default().enabled); | ||
| } | ||
|
|
||
| #[test] | ||
| fn it_should_not_format_when_enabled_is_false() { | ||
| let snippet = setup_snippet(INPUT, EXTENSION).expect("it to save the file"); | ||
| let snippet_path = snippet.path(); | ||
|
|
||
| assert!(Lang::<Erlang> { | ||
| enabled: false, | ||
| formatter: MdsfFormatter::Single(Erlang::default()) | ||
| } | ||
| .format(snippet_path) | ||
| .expect("it to not fail") | ||
| .is_none()); | ||
| } | ||
|
|
||
| #[test_with::executable(erlfmt)] | ||
| #[test] | ||
| fn test_erlfmt() { | ||
| let l = Lang::<Erlang> { | ||
| enabled: true, | ||
| formatter: MdsfFormatter::Single(Erlang::Erlfmt), | ||
| }; | ||
|
|
||
| let snippet = setup_snippet(INPUT, EXTENSION).expect("it to save the file"); | ||
| let snippet_path = snippet.path(); | ||
|
|
||
| let output = l | ||
| .format(snippet_path) | ||
| .expect("it to not fail") | ||
| .expect("it to be a snippet"); | ||
|
|
||
| let expected_output = "what_is(Erlang) -> | ||
| case Erlang of | ||
| movie -> [hello(mike, joe, robert), credits]; | ||
| language -> no_more_formatting_arguments | ||
| end."; | ||
|
|
||
| assert_eq!(output, expected_output); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters