Implemented: Added the support for using facility selector from dxp-component(#dxp/228) #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravilodhi
reviewed
Nov 6, 2024
package.json
Outdated
| @@ -16,8 +16,8 @@ | |||
| "@casl/ability": "^6.0.0", | |||
| "@hotwax/app-version-info": "^1.0.0", | |||
| "@hotwax/apps-theme": "^1.2.6", | |||
| "@hotwax/dxp-components": "^1.13.0", | |||
| "@hotwax/oms-api": "^1.14.0", | |||
| "@hotwax/dxp-components": "file:../dxp-components", | |||
There was a problem hiding this comment.
Published the latest version of dxp-components. Please use the same here.
ravilodhi
reviewed
Nov 6, 2024
package.json
Outdated
| "@hotwax/dxp-components": "^1.13.0", | ||
| "@hotwax/oms-api": "^1.14.0", | ||
| "@hotwax/dxp-components": "file:../dxp-components", | ||
| "@hotwax/oms-api": "file:../oms-api", |
There was a problem hiding this comment.
Same here. Use the latest oms-api version here.
ravilodhi
reviewed
Nov 6, 2024
src/store/modules/order/actions.ts
Outdated
| import emitter from "@/event-bus"; | ||
| import store from "@/store"; | ||
|
|
||
| const getCurrentFacilityId = () => { |
There was a problem hiding this comment.
Can we add a util function for this?
ravilodhi
reviewed
Nov 6, 2024
src/store/modules/user/actions.ts
Outdated
| async setFacility ({ commit, dispatch }, payload) { | ||
| const eComStore = await UserService.getEComStores(undefined, payload.facility.facilityId); | ||
|
|
||
| async setFacilityUpdates ({ commit, dispatch, state }, payload) { |
There was a problem hiding this comment.
Rename payload to facilityId.
… & changed functions name(#dxp/288) - Updated the dxp-components & oms-api to latest versions.
ravilodhi
reviewed
Nov 8, 2024
src/store/modules/order/actions.ts
Outdated
|
|
||
| if (current.length && current[0]?.orderId === orderId) { return current } | ||
|
|
||
| else if(orders.length > 0) { |
There was a problem hiding this comment.
What is the purpose of this change?
1 task
ravilodhi
reviewed
Nov 18, 2024
src/store/modules/order/actions.ts
Outdated
| @@ -70,6 +70,7 @@ const actions: ActionTree<OrderState, RootState> = { | |||
| }, | |||
| async getOrderDetail({ commit, state }, { orderId }) { | |||
| let resp; | |||
| const currentFacilityId = getCurrentFacilityId(); | |||
There was a problem hiding this comment.
Use the getCurrentFacilityId() directly if currentFacilityId is not reused.
ravilodhi
reviewed
Nov 18, 2024
src/store/modules/order/actions.ts
Outdated
| @@ -208,7 +209,8 @@ const actions: ActionTree<OrderState, RootState> = { | |||
| "orderBy": 'datetimeReceived DESC', | |||
| "viewSize": "250" | |||
| } | |||
| const facilityLocations = await this.dispatch('user/getFacilityLocations', this.state.user.currentFacility.facilityId); | |||
| const currentFacilityId = getCurrentFacilityId() | |||
There was a problem hiding this comment.
Use the getCurrentFacilityId() directly if currentFacilityId is not reused.
ravilodhi
reviewed
Nov 18, 2024
| @@ -72,8 +72,8 @@ const actions: ActionTree<ShipmentState, RootState> = { | |||
| const shipmentAttributes = await ShipmentService.fetchShipmentAttributes([shipmentDetail.shipmentId]) | |||
| shipmentDetail.externalOrderId = shipmentAttributes?.[shipmentDetail.shipmentId]?.['EXTERNAL_ORDER_ID'] | |||
| shipmentDetail.externalOrderName = shipmentAttributes?.[shipmentDetail.shipmentId]?.['EXTERNAL_ORDER_NAME'] | |||
|
|
|||
| const facilityLocations = await this.dispatch('user/getFacilityLocations', this.state.user.currentFacility.facilityId); | |||
| const currentFacilityId = getCurrentFacilityId(); | |||
…lity instead of useUserStore from dxp-component in various files(#dxp/288)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
hotwax/dxp-components#228
Short Description and Why It's Useful
facility selectoron the settings page from thedxp-component.statemanagement.gettersfrom the user store in dxp-components across the entire application.Contribution and Currently Important Rules Acceptance