-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented: product identifier component receiving app from dxp-components(#267) #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Jul 22, 2024
ymaheshwari1
requested changes
Jul 23, 2024
…ow using it from DXP
ymaheshwari1
requested changes
Jul 23, 2024
ymaheshwari1
requested changes
Jul 23, 2024
…to fetch the product identification options from dxp
…to fetch the product identification options from dxp
Ridwan6947
changed the title
Implemented: product identifier component receiving app from dxp-components(#267-v1)
Implemented: product identifier component receiving app from dxp-components(#267)
Jul 24, 2024
… changed code logic for getBarcodeIdentificationValue mutation (hotwax#267)
ymaheshwari1
approved these changes
Jul 24, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#267
Short Description and Why It's Useful
Added product-Identifier Dxp component on settings page and changed internal code logic to fetch primary and secondary from Dxp component
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance