Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: empty state UI for filters(#165) #255

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Aug 27, 2024

Related Issues

#165

Short Description and Why It's Useful

  • Removed unwanted strings Add <name> filters/rules from empty state
  • Removed breaking of learn more string in inventory filter empty state.

Screenshots of Visual Changes before/after (If There Are Any)

Before:

image

After:

image

Contribution and Currently Important Rules Acceptance

@ymaheshwari1 ymaheshwari1 requested a review from dt2patel August 27, 2024 13:06
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ymaheshwari1 ymaheshwari1 merged commit 028ff9c into hotwax:main Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants