Fixed: the click issue in ion-select when used inside ion-chip(#167) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#167) As the ion-chip and ion-select has some padding between them when using ion-select inside ion-chip, if the user clicks outside of ion-select, but inside ion-chip in the padding part, the ion-select popover does not opens up. Added support to override the ion-select click event and added a click event on ion-chip to programatically trigger the ion-select event when user performs a click action anywhere inside ion-chip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related Issue #167
Short Description and Why It's Useful
As the ion-chip and ion-select has some padding between them when using ion-select inside ion-chip, if the user clicks outside of ion-select, but inside ion-chip in the padding part, the ion-select popover does not opens up.
Added support to override the ion-select click event and added a click event on ion-chip to programmatically trigger the ion-select event when user performs a click action anywhere inside ion-chip
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance