Fixed: issue in filter option persistence and field overridden issue in filter and sort options(#146) #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the rules page(hotwax#146) When creating multiple rules and saving their filters at once, and if moving to the route page and again coming to the rules page, it displays the data from the state instead of fetching the latest information, thus added an action to clear the rules once the page is left so that always the latest information for the rules is fetched
When having same fieldName in sort and filter options and adding/removing that field in both filter and sort, then always the sort option is honored and the filter option is ignored, as the filter field key gets overridden by the sort key inside the object. Updated the keys after finding the diff to include filter and sort string in the respective options, to handle the override property issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related Issue #146
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance