Merge pull request #144 from ymaheshwari1/#141

Improved: check for rule and route name fields(#141)
hotwax · Apr 1, 2024 · ee8f630 · ee8f630
2 parents 1d9c861 + 8d57a26
commit ee8f630
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/views/BrokeringQuery.vue b/src/views/BrokeringQuery.vue
@@ -254,7 +254,7 @@ import { onBeforeRouteLeave, useRouter } from "vue-router";
 import { computed, defineProps, ref } from "vue";
 import store from "@/store";
 import AddInventoryFilterOptionsModal from "@/components/AddInventoryFilterOptionsModal.vue";
-import { getDateAndTimeShort, sortSequence } from "@/utils";
+import { getDateAndTimeShort, showToast, sortSequence } from "@/utils";
 import { Rule } from "@/types";
 import AddOrderRouteFilterOptions from "@/components/AddOrderRouteFilterOptions.vue"
 import PromiseFilterPopover from "@/components/PromiseFilterPopover.vue"
@@ -497,7 +497,13 @@ async function addInventoryRule() {
       text: translate("Cancel"),
       role: "cancel"
     }, {
-      text: translate("Save")
+      text: translate("Save"),
+      handler: (data) => {
+        if(!data.ruleName?.trim().length) {
+          showToast(translate("Please enter a valid name"))
+          return false;
+        }
+      }
     }],
     inputs: [{
       name: "ruleName",

diff --git a/src/views/BrokeringRoute.vue b/src/views/BrokeringRoute.vue
@@ -387,7 +387,13 @@ async function createOrderRoute() {
       text: translate("Cancel"),
       role: "cancel"
     }, {
-      text: translate("Save")
+      text: translate("Save"),
+      handler: (data) => {
+        if(!data.routingName?.trim().length) {
+          showToast(translate("Please enter a valid name"))
+          return false;
+        }
+      }
     }],
     inputs: [{
       name: "routingName",