Merge pull request #168 from ymaheshwari1/#166

Improved: UI for the routing history to display message when no history is present and added lines full to have separation between the history modal title and its details(#166)
hotwax · Apr 8, 2024 · e3c8c75 · e3c8c75
2 parents a97cc8c + ac06db4
commit e3c8c75
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/components/RoutingHistoryModal.vue b/src/components/RoutingHistoryModal.vue
@@ -12,7 +12,7 @@
 
   <ion-content>
     <ion-list>
-      <ion-item>
+      <ion-item lines="full">
         <ion-label>
           <h1>{{ routingName }}</h1>
           <p>{{ groupName }}</p>

diff --git a/src/locales/en.json b/src/locales/en.json
@@ -79,6 +79,7 @@
   "No available history for this group": "No available history for this group",
   "No available history for this route": "No available history for this route",
   "No archived routings": "No archived routings",
+  "No run history": "No run history",
   "No runs scheduled": "No runs scheduled",
   "No time zone found": "No time zone found",
   "OMS": "OMS",

diff --git a/src/views/BrokeringRoute.vue b/src/views/BrokeringRoute.vue
@@ -36,7 +36,7 @@
                   <ion-icon :icon="timeOutline" slot="start" />
                   <ion-label>{{ translate("Last run") }}</ion-label>
                   <ion-chip outline @click.stop="openRoutingHistoryModal(routing.orderRoutingId, routing.routingName)">
-                    <ion-label>{{ routingHistory[routing.orderRoutingId] ? getDateAndTimeShort(routingHistory[routing.orderRoutingId][0].startDate) : "-" }}</ion-label>
+                    <ion-label>{{ routingHistory[routing.orderRoutingId] ? getDateAndTimeShort(routingHistory[routing.orderRoutingId][0].startDate) : translate("No run history") }}</ion-label>
                   </ion-chip>
                 </ion-item>
                 <ion-item lines="none">