Customer deposit view entity #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixitdeepak
reviewed
Dec 30, 2024
entity/CustomerDepositView.xml
Outdated
| <member-entity entity-alias="OISG" entity-name="org.apache.ofbiz.order.order.OrderItemShipGroup" join-from-alias="OH"> | ||
| <key-map field-name="orderId"/> | ||
| </member-entity> | ||
| <member-entity entity-alias="DCO" entity-name="co.hotwax.order.DirectCancelOrder" join-from-alias="OH" sub-select="true" join-optional="true"> |
There was a problem hiding this comment.
It's not recommended to include the ViewEntity an another view entity, it will create complex join and cause performance issue.
Instead use the entities directly
There was a problem hiding this comment.
@dixitdeepak do you have a suggestion of when we should use sub select? how will we know if it is right time to use it?
There was a problem hiding this comment.
will generate the SQL for all the views where we are using the sub-select, for further analysis.
…nector into customer-deposit-view-entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two views in the component