Improved: Added a function to set the ion-badge color based on log status and updated the 'Failed Records' icon properties (#680) #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atus and updated the 'Failed Records' icon properties (hotwax#680)
ymaheshwari1
requested changes
Nov 18, 2024
…sary case in getLogStatusColor function(hotwax#680)
ymaheshwari1
approved these changes
Nov 27, 2024
dt2patel
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#680
Short Description and Why It's Useful
ion-badgecolor for the log item based on thestatusId.Failed recordsion-icon, such as slot and color.Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance