Implemented: spinner in timezone modal for timezone configuration(#233) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Jan 4, 2024
|
@shanmukhdutt Can you please attach a screenshot in the PR description? |
ymaheshwari1
requested changes
Jan 5, 2024
ymaheshwari1
requested changes
Jan 5, 2024
ymaheshwari1
requested changes
Jan 12, 2024
src/views/TimezoneModal.vue
Outdated
| @@ -126,6 +136,7 @@ export default defineComponent({ | |||
| }); | |||
| }, | |||
| async getAvailableTimeZones() { | |||
| // this.isLoading = true | |||
There was a problem hiding this comment.
Why we have commented this line?
| @@ -13,11 +13,18 @@ | |||
| </ion-toolbar> | |||
| </ion-header> | |||
|
|
|||
|
|
|||
ymaheshwari1
requested changes
Jan 29, 2024
| } | ||
|
|
||
| .empty-state { |
There was a problem hiding this comment.
The styling needs to be added above the media-query styles
shanmukhdutt
changed the title
|
Closing as fixed in #263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #233
Short Description and Why It's Useful
Screenshots of Visual Changes before/after
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance