Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: code for time modal in customScheduleModal (#44) #65

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Improved: code for time modal in customScheduleModal (#44) #65

merged 6 commits into from
Dec 5, 2023

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Dec 4, 2023 •
edited
Loading

Related Issues

Closes #44

Short Description and Why It's Useful

Improved the code for time picker in customSchedule modal.

  • Improved code to only use one ion-datetime picker with ion-chip for selecting time.
  • Improved code to add a close button in chip to clear selected time.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2023-12-04 18-41-29
Screenshot from 2023-12-05 09-34-55

Contribution and Currently Important Rules Acceptance

@amansinghbais amansinghbais marked this pull request as ready for review December 4, 2023 14:11
@ravilodhi ravilodhi merged commit 6bd7749 into hotwax:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymaheshwari1 ymaheshwari1 ymaheshwari1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Close time picker on clear action
3 participants
@amansinghbais @ymaheshwari1 @ravilodhi